Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ll-cli run deepin-movie #333

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

rb-union
Copy link
Contributor

Temporarily use ll-cli run deepin-movie, instead of DBus interface.
It seems that deepin-movie takes more time to start, causeing method calls to not respond.

Log: Fix start deepin-movie but not play.
Bug: https://pms.uniontech.com/bug-view-294085.html

Temporarily use ll-cli run deepin-movie, instead of
DBus interface.
It seems that deepin-movie takes more time to start,
causeing method calls to not respond.

Log: Fix start deepin-movie but not play.
Bug: https://pms.uniontech.com/bug-view-294085.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • #if 1#else分支中,programarguments变量在#else分支中被重新赋值,但在#if 1分支中并没有被使用,可能会导致逻辑错误。
  • qDebug()qWarning()的使用应该更加规范,例如添加文件名和行号信息,以便于调试和问题追踪。
  • QProcessstartDetached方法在#if 1分支中被使用,但没有检查返回值,应该添加错误处理逻辑。
  • #ifdef OS_BUILD_V23被修改为#if defined(OS_BUILD_V23) || defined(OS_BUILD_V25),这可能会影响其他依赖于OS_BUILD_V23的代码,需要确认是否有相关的修改。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@pengfeixx pengfeixx merged commit 6e53a42 into linuxdeepin:master Dec 13, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants