Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 优化相机显示与录制卡顿回跳问题 #340

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Dec 20, 2024

优化相机显示与录制卡顿回跳问题

Bug: https://pms.uniontech.com/bug-view-293127.html
Log: 优化相机显示与录制卡顿回跳问题

优化相机显示与录制卡顿回跳问题

Bug: https://pms.uniontech.com/bug-view-293127.html
Log: 优化相机显示与录制卡顿回跳问题
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. encoder.c文件中,is_forceGles()函数的调用应该确保其定义和实现是正确的,并且函数返回值类型与pgux的类型一致。

  2. majorimageprocessingthread.cpp文件中,emit sigRenderYuv(true);被注释掉了,如果这是有意为之,应该添加注释说明原因。如果这个信号不再需要,应该移除相关代码。

  3. previewopenglwidget.cpp文件中,glTexImage2D函数的调用被修改为在bReBuildImagetrue时使用0作为数据指针,这可能会导致纹理数据未正确加载。应该检查bReBuildImage的逻辑,确保在需要重建纹理时正确处理数据指针。

  4. previewopenglwidget.cpp文件中,glTexSubImage2D函数的调用应该在bReBuildImagefalse时执行,以避免不必要的纹理重建。

  5. previewopenglwidget.h文件中,新增了m_imgSize成员变量,但没有提供相应的初始化代码。应该在类的构造函数中初始化这个变量。

  6. videowidget.cpp文件中,ReceiveOpenGLstatus(true);的调用应该在m_openglwidget可见时执行,但这个调用应该放在resizeEvent函数中,而不是resizeEvent函数的末尾。这样可以在窗口大小改变时正确更新OpenGL状态。

  7. videowidget.cpp文件中,resizeEvent函数中新增的ReceiveOpenGLstatus(true);调用应该检查m_openglwidget是否为nullptr,以避免潜在的空指针解引用。

  8. videowidget.cpp文件中,resizeEvent函数中新增的ReceiveOpenGLstatus(true);调用应该在resizeEvent函数的末尾,以确保在窗口大小改变时正确更新OpenGL状态。

  9. videowidget.cpp文件中,resizeEvent函数中新增的ReceiveOpenGLstatus(true);调用应该检查m_openglwidget是否为nullptr,以避免潜在的空指针解引用。

  10. videowidget.cpp文件中,resizeEvent函数中新增的ReceiveOpenGLstatus(true);调用应该在resizeEvent函数的末尾,以确保在窗口大小改变时正确更新OpenGL状态。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343
Copy link
Contributor Author

myk1343 commented Dec 20, 2024

/merge

@deepin-bot deepin-bot bot merged commit 7855880 into linuxdeepin:release/eagle Dec 20, 2024
14 checks passed
@myk1343 myk1343 deleted the uploadcode branch December 30, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants