Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid url #344

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

wyu71
Copy link
Contributor

@wyu71 wyu71 commented Dec 20, 2024

remove invalid url

Log: remove invalid url

remove invalid  url

Log: remove invalid  url
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 注释更新

    • 在多个文件的mouseMoveEvent函数中,注释已经从包含完整的bug链接更新为仅包含bug编号。这是一个好的做法,因为它使得注释更加简洁,并且更容易查找相关的bug报告。
  2. 代码重复

    • circlePushButtonfilterPreviewButtonImageItemphotoRecordBtnQGraphicsViewExmouseMoveEvent函数中,代码是完全相同的。这表明这些函数可能应该被合并为一个通用的函数,以减少代码重复。
  3. 未使用的参数

    • mouseMoveEvent函数中,Q_UNUSED(event);宏被用来标记event参数为未使用。这是一个好的做法,可以避免编译器警告。但是,如果这些函数将来可能会使用event参数,那么应该保留这个宏,或者删除它。
  4. 代码风格

    • QGraphicsViewEx的构造函数中,注释的格式不一致。有些注释使用的是中文,有些使用的是英文。建议统一使用一种语言,以提高代码的可读性。
  5. 代码可维护性

    • 如果mouseMoveEvent函数将来需要添加更多的逻辑,那么将这些逻辑集中到一个通用的函数中将会使代码更加易于维护。

综上所述,代码的注释已经更新,并且可以通过合并重复的mouseMoveEvent函数来减少代码重复,提高代码的可维护性。同时,应该统一注释的语言,以提高代码的可读性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wyu71 wyu71 merged commit 6c8f6b9 into linuxdeepin:release/1050U1 Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants