Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid url #345

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

wyu71
Copy link
Contributor

@wyu71 wyu71 commented Dec 20, 2024

remove invalid url

Log: remove invalid url

remove invalid  url

Log: remove invalid  url
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 注释更新

    • 在多个文件的mouseMoveEvent函数中,注释已经从包含完整的bug链接更新为仅包含bug编号。这是一个好的做法,因为它使得注释更加简洁,并且更容易查找相关的bug信息。
  2. 代码重复

    • circlePushButton.cppfilterPreviewButton.cppimageitem.cppphotorecordbtn.cppvideowidget.cpp中,mouseMoveEvent函数的实现完全相同,只是注释中的bug编号不同。这些函数的功能看起来是相似的,可以考虑将它们合并为一个通用的函数,以减少代码重复。
  3. 未使用的参数

    • mouseMoveEvent函数中,使用了Q_UNUSED(event);来忽略event参数。这是一个好的做法,可以避免编译器警告。但是,如果这些函数将来可能会使用event参数,那么应该保留这个注释,并确保在需要时使用它。
  4. 注释清晰度

    • videowidget.cpp中,注释“bug链接”被更新为“bug 100791”,这是一个好的改进,使得注释更加简洁和易于理解。
  5. 代码风格

    • videowidget.cpp中,注释“bug链接”和“bug 100791”之间没有空行分隔。虽然这不是一个错误,但为了保持代码风格的统一,建议在注释之间添加一个空行。

综上所述,代码的注释已经得到了改进,但是存在一些代码重复和风格上的小问题。建议将相似的函数合并,并保持代码风格的统一。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wyu71 wyu71 merged commit 49abf55 into linuxdeepin:release/eagle Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants