Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复mips问题 #348

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Jan 7, 2025

修复mips问题

Log: 修复mips问题

修复mips问题

Log: 修复mips问题
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • resizeEvent函数中,添加了条件编译指令#ifndef __mips__,这可能是为了解决特定平台上的问题,但需要确认是否所有相关平台都适用。
  • resizeEvent函数中,ReceiveOpenGLstatus(true);的调用可能需要更多的上下文信息来确认其正确性,例如是否所有情况下都需要调用此函数。

是否建议立即修改:

  • 是,需要确保条件编译指令#ifndef __mips__的使用是必要的,并且不会对其他平台造成影响。
  • 是,如果ReceiveOpenGLstatus(true);的调用不是所有情况下都需要,应该添加注释说明其用途,或者根据具体情况进行优化。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343
Copy link
Contributor Author

myk1343 commented Jan 8, 2025

/merge

@deepin-bot deepin-bot bot merged commit d70d7c5 into linuxdeepin:release/eagle Jan 8, 2025
17 checks passed
@myk1343 myk1343 deleted the uploadcode branch January 9, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants