Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile error #491

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: compile error #491

merged 1 commit into from
Jul 10, 2024

Conversation

pengfeixx
Copy link
Contributor

ffmpeg api error

Log: compile error

ffmpeg api error

Log: compile error
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • playlist_model.cpp中,mvideo_avcodec_open2mvideo_avcodec_free_context函数的声明和定义之间存在差异,这可能会导致编译错误或未定义的行为。
  • playlist_model.h中,DGUI_USE_NAMESPACEDWIDGET_USE_NAMESPACE的顺序被更改,但没有提供上下文来解释为什么这样做。
  • toolbutton.h中,QTimer的包含顺序被更改,但没有提供上下文来解释为什么这样做。

是否建议立即修改:

  • 是,建议立即检查playlist_model.cppplaylist_model.h中的函数声明和定义,以确保它们之间的匹配。
  • 是,建议立即检查toolbutton.h中的包含顺序,以确保它们不会引起编译错误或未定义的行为。

@myk1343
Copy link
Contributor

myk1343 commented Jul 9, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx pengfeixx merged commit 60e31e9 into linuxdeepin:release/eagle Jul 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants