Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing Package Depends qml6-module-qtquick-dialogs #481

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

xoascf
Copy link
Contributor

@xoascf xoascf commented Aug 25, 2024

No description provided.

@deepin-ci-robot
Copy link

Hi @xoascf. Thanks for your PR. 😃

Copy link
Contributor

github-actions bot commented Aug 25, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@deepin-ci-robot
Copy link

Hi @xoascf. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xoascf
Copy link
Contributor Author

xoascf commented Aug 25, 2024

I have read the CLA Document and I hereby sign the CLA.

deepin-bot bot added a commit to linuxdeepin/cla that referenced this pull request Aug 25, 2024
@BLumia BLumia requested review from babyfengfjx and removed request for babyfengfjx September 2, 2024 05:46
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, xoascf

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
Copy link
Member

BLumia commented Sep 2, 2024

/test all

@BLumia
Copy link
Member

BLumia commented Sep 2, 2024

/test all

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • debian/control文件中添加了新的依赖项qml6-module-qtquick-dialogs,需要确认是否所有目标用户都需要这个依赖。
  • 检查是否有对应的单元测试来验证新增依赖项的兼容性和稳定性。

是否建议立即修改:

  • 是,应该立即解决依赖项的兼容性和稳定性问题,并确保代码库中包含了必要的单元测试。

@BLumia BLumia merged commit 6a9abd1 into linuxdeepin:master Sep 2, 2024
14 checks passed
@xoascf xoascf deleted the patch-1 branch September 2, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants