Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the issue that the scrollbar was blank #485

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

pengfeixx
Copy link
Contributor

Fixed the issue that the scrollbar was blank

Bug: https://pms.uniontech.com/bug-view-273487.html
Log: Fixed the issue that the scrollbar was blank

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftPadding 直接移掉显示效果有影响

Fixed the issue that the scrollbar was blank

Bug: https://pms.uniontech.com/bug-view-273487.html
Log: Fixed the issue that the scrollbar was blank
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • MusicBaselistview.qml中,contentHeight的计算表达式被移除,但未看到对应的height属性设置,可能会导致布局问题。
  • SideBarItem.qml中,fillHeight属性被添加,但未看到对应的属性使用,应确认是否有必要添加此属性。
  • SideBarItem.qml中,clip属性被设置为true,这可能会影响布局,应确保这是预期的行为。
  • SideBarItem.qml中,boundsBehavior属性被设置为Flickable.StopAtBounds,这可能会影响用户交互,应确保这是预期的行为。

是否建议立即修改:

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link
Contributor

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 12, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 26667d6 into linuxdeepin:master Sep 12, 2024
15 of 17 checks passed
@pengfeixx pengfeixx deleted the bugfix branch September 12, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants