Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile error #496

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

rb-union
Copy link
Contributor

@rb-union rb-union commented Jul 9, 2024

Fix compile error: duplicate macro definition,
QUICK_ITEM_KEY defined in dde-dock.

Log: fix complie error

Fix compile error: duplicate macro definition,
QUICK_ITEM_KEY defined in dde-dock.

Log: fix complie error
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • shotstartplugin.cppshotstartrecordplugin.cpp中,QUICK_ITEM_KEY的定义使用了预处理器指令#ifndef,这是一个好的做法,因为它可以避免在编译时重复定义相同的常量。

是否建议立即修改:

  • 否,当前的代码改动看起来是合理的,没有发现需要立即修改的问题。但是,建议进行以下几点额外的审查:
    • 确认QUICK_ITEM_KEY的定义是否在其他文件中也有使用,以保证一致性。
    • 检查DETECT_SERV_INTERVAL的定义是否在其他文件中也使用了相同的预处理器指令。
    • 确保所有相关的预处理器指令都已经过充分测试,以避免潜在的编译错误。
    • 如果QUICK_ITEM_KEY在其他文件中没有使用,建议考虑移除这个预处理器指令,因为它可能会导致编译后的代码中包含未使用的常量定义。

@myk1343
Copy link
Contributor

myk1343 commented Jul 9, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link

@starhcq starhcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union
Copy link
Contributor Author

rb-union commented Jul 9, 2024

/merge

1 similar comment
@rb-union
Copy link
Contributor Author

rb-union commented Jul 9, 2024

/merge

@deepin-bot deepin-bot bot merged commit 1afa389 into linuxdeepin:release/eagle Jul 9, 2024
7 checks passed
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 9, 2024

This pr cannot be merged! (status: unknown)

@pengfeixx
Copy link

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 9, 2024

This pr cannot be merged! (status: unknown)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants