Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the toolbar incorrect coordinate position display #501

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: the toolbar incorrect coordinate position display #501

merged 1 commit into from
Jul 12, 2024

Conversation

add-uos
Copy link
Contributor

@add-uos add-uos commented Jul 12, 2024

the toolbar incorrect coordinate position display

Log: the toolbar incorrect coordinate position display
Bug: https://pms.uniontech.com/bug-view-261623.html

the toolbar incorrect coordinate position display

Log: the toolbar incorrect coordinate position display
Bug: https://pms.uniontech.com/bug-view-261623.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • getTwoScreenIntersectPos 函数中存在重复计算,可以考虑将计算结果缓存以提高性能。
  • getTwoScreenIntersectPos 函数中的条件判断较为复杂,可以考虑简化逻辑或添加注释以提高代码可读性。
  • getTwoScreenIntersectPos 函数中的变量命名(如 xy)不够具体,建议使用更有意义的变量名以提高代码可读性。
  • getTwoScreenIntersectPos 函数中的 if-else 结构较多,可以考虑使用其他编程语言中的 switch 语句或模板方法来简化代码。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@add-uos
Copy link
Contributor Author

add-uos commented Jul 12, 2024

/merge

@deepin-bot deepin-bot bot merged commit ac72404 into linuxdeepin:release/eagle Jul 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants