Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the taskbar display incorrectly #503

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix: the taskbar display incorrectly #503

merged 1 commit into from
Jul 17, 2024

Conversation

add-uos
Copy link
Contributor

@add-uos add-uos commented Jul 17, 2024

During screen recording, the system time was modified,
and the screen recorthe taskbar was displayed incorrectly

Log: the temporal performance of recording gif
Bug: https://pms.uniontech.com/bug-view-258049.html
https://pms.uniontech.com/bug-view-258049.html

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@@ -140,8 +142,7 @@ void TimeWidget::onTimeout()
}
m_bRefresh = !m_bRefresh;
QTime showTime(0, 0, 0);
int time = m_baseTime.secsTo(QTime::currentTime());
showTime = showTime.addSecs(time);
showTime = showTime.addMSecs(m_timerCount * 400);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自己计算时间的话,建议添加到多线程里面去,或者修改时间停止录制视频。

During screen recording, the system time was modified,
and the screen recorthe taskbar was displayed incorrectly

Log: the temporal performance of recording gif
Bug: https://pms.uniontech.com/bug-view-258049.html
     https://pms.uniontech.com/bug-view-263253.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • TimeWidget构造函数中新增了m_timerCount成员变量,但未在类文档中说明其用途。
  • onTimeout函数中使用m_timerCount递增,但没有明确的逻辑来解释这一变化。
  • onTimeout函数中的showTime变量被修改为使用毫秒而不是秒,这可能影响计时器的效果。
  • start函数中新增了m_timerCount的初始化,但没有相应的注释说明这一变化。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@add-uos
Copy link
Contributor Author

add-uos commented Jul 17, 2024

/merge

@deepin-bot deepin-bot bot merged commit ce66128 into linuxdeepin:release/eagle Jul 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants