Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust border size parameters for narrow images #607

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

rb-union
Copy link
Contributor

Adjust SVG center size and point parameters,
fix incomplete display of long and narrow images
when applying borders.

Log: Adjust border size parameters for narrow images

Adjust SVG center size and point parameters,
fix incomplete display of long and narrow images
when applying borders.

Log: Adjust border size parameters for narrow images
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. main.cpp文件中,移除了qInfo()打印Utils::isWaylandMode的语句,这可能会影响调试和问题追踪。如果这个信息不再需要,请确认是否有替代的日志记录方式或者是否已经不再需要这些信息。

  2. main.cpp文件中,添加了Utils::isTreelandMode的打印信息,这是一个好的做法,可以帮助开发者了解当前环境是否是Treeland模式。

  3. borderprocessinterface.cpp文件中,修改了多个QSizeFQPointF的值,这些修改可能是为了适应新的设计需求或者修复了某些问题。但是,这些修改可能会导致界面布局的变化,需要确保这些变化不会影响用户体验。

  4. borderprocessinterface.cpp文件中,QPointF的值从浮点数改为整数,这可能会影响精度。如果这些值需要精确到小数点后几位,建议保留浮点数类型。

  5. borderprocessinterface.cpp文件中,QSizeFQPointF的值被修改,但没有提供修改的原因或说明。建议添加注释来解释为什么需要这些修改,以便其他开发者理解。

  6. borderprocessinterface.cpp文件中,QSizeFQPointF的值被修改,但没有进行边界检查或验证。如果这些值用于计算或绘制,建议添加适当的检查来确保它们在有效范围内。

  7. borderprocessinterface.cpp文件中,QSizeFQPointF的值被修改,但没有进行单元测试来验证这些修改是否正确。建议添加单元测试来确保这些修改不会引入新的错误。

总体来说,代码的修改看起来是为了适应新的需求或修复问题,但是需要确保这些修改不会引入新的问题,并且需要添加适当的注释和测试来保证代码的质量和可靠性。

Copy link
Contributor

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit b7c62ec into linuxdeepin:develop/snipe Jan 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants