Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkgui #100

Merged
merged 1 commit into from
Jan 1, 2025
Merged

sync: from linuxdeepin/dtkgui #100

merged 1 commit into from
Jan 1, 2025

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#294

Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#294
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • 在新增代码中,font.setFamilies(base.families()); 可能会导致不必要的性能开销,因为每次调用 get 方法时都会重新设置字体家族。
  • 新增代码没有对 base.families() 的返回值进行空值检查,如果 base 为空,可能会导致运行时错误。

是否建议立即修改:

@mhduiy mhduiy merged commit 5715984 into master Jan 1, 2025
11 of 13 checks passed
@mhduiy mhduiy deleted the sync-pr-294-nosync branch January 1, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants