Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkgui #84

Merged
merged 1 commit into from
Nov 27, 2024
Merged

sync: from linuxdeepin/dtkgui #84

merged 1 commit into from
Nov 27, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#279

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-279-nosync branch 3 times, most recently from bce25dd to 617cf16 Compare November 27, 2024 01:58
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#279
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DWindowManagerHelper::instance()函数中,treelandWMHGlobal被直接返回,但没有检查其是否为空或未初始化。
  • TreelandWindowManagerHelper类中的信号hasBlurWindowChanged()hasNoTitlebarChanged()PersonalizationManager::activeChanged信号连接时被发射,但没有检查PersonalizationManager实例是否为空或未初始化。
  • TreelandWindowManagerHelper类中的hasBlurWindow()hasComposite()hasNoTitlebar()函数直接返回PersonalizationManager::instance()->isSupported(),但没有处理PersonalizationManager实例可能为空的情况。

是否建议立即修改:

  • 应该在DWindowManagerHelper::instance()函数中添加对treelandWMHGlobal的空值检查。
  • TreelandWindowManagerHelper类中,应该添加对PersonalizationManager::instance()的空值检查,并确保在PersonalizationManager实例为空时不会发射信号。
  • TreelandWindowManagerHelper类中的hasBlurWindow()hasComposite()hasNoTitlebar()函数中,应该添加对PersonalizationManager::instance()的空值检查,并处理可能为空的情况。

@18202781743 18202781743 merged commit e25e766 into master Nov 27, 2024
10 of 13 checks passed
@18202781743 18202781743 deleted the sync-pr-279-nosync branch November 27, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants