chore: add some interfaces about personalization #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: FeiWang1119 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 10, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 10, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 11, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 11, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
kegechen
requested review from
justforlxz and
18202781743
and removed request for
justforlxz
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
18202781743
reviewed
Oct 14, 2024
zccrs
requested changes
Oct 14, 2024
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 15, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 15, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 15, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 15, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 15, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin pr auto review |
zccrs
requested changes
Oct 15, 2024
include/kernel/dplatforminterface.h
Outdated
include/kernel/dplatforminterface.h
Outdated
| virtual int windowRadius() const; | ||
| virtual void setWindowRadius(int windowRadius); | ||
| virtual QByteArray fontName() const; | ||
| virtual void setFontName(const QByteArray &fontName); |
There was a problem hiding this comment.
这种系统全局类的配置的修改不在 dtkgui 里提供，dtkgui里只读，不实现修改的功能。
There was a problem hiding this comment.
就算要做修改的功能，也应该是在 dtksystemsettings 模块里做。
include/kernel/dplatforminterface.h
Outdated
| virtual ~DPlatformInterface(); | ||
|
|
||
| virtual int windowRadius() const; | ||
| virtual void setWindowRadius(int windowRadius); |
There was a problem hiding this comment.
作为一个单独的cmake模块放到一个子目录里，目录以 plugins/platform 开头，比如是 plugins/platform/xcb
src/kernel/dplatformhandle.cpp
Outdated
| if (contextWindow->noTitlebar() == enable) | ||
| return true; | ||
| contextWindow->setNoTitlebar(enable); | ||
| #ifndef DTK_DISABLE_TREELAND |
src/kernel/dplatformhandle.cpp
Outdated
| @@ -1209,6 +1203,12 @@ WId DPlatformHandle::windowLeader() | |||
|
|
|||
| void DPlatformHandle::setWindowRadius(int windowRadius) | |||
| { | |||
| #ifndef DTK_DISABLE_TREELAND | |||
| if (DGuiApplicationHelper::testAttribute(DGuiApplicationHelper::IsTreelandPlatform)) { | |||
src/kernel/dplatforminterface.cpp
Outdated
| { | ||
| } | ||
|
|
||
| int DPlatformInterface::windowRadius() const |
src/kernel/dplatformtheme.cpp
Outdated
| @@ -19,7 +26,6 @@ DGUI_BEGIN_NAMESPACE | |||
| DPlatformThemePrivate::DPlatformThemePrivate(Dtk::Gui::DPlatformTheme *qq) | |||
| : DNativeSettingsPrivate(qq, QByteArrayLiteral("/deepin/palette")) | |||
| { | |||
|
|
|||
| : QWaylandClientExtensionTemplate<PersonalizationManager>(1) | ||
| { | ||
| if (QGuiApplication::platformName() == QLatin1String("wayland")) { | ||
| QtWaylandClient::QWaylandIntegration *waylandIntegration = static_cast<QtWaylandClient::QWaylandIntegration *>(QGuiApplicationPrivate::platformIntegration()); |
There was a problem hiding this comment.
Qt6版本不是这样使用了吧，它不是有了 QNativeInterface 这种东西
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 17, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Oct 17, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
|
TAG Bot New tag: 5.7.1 |
|
TAG Bot New tag: 5.7.2 |
|
TAG Bot New tag: 5.7.3 |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Nov 28, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
add window platform interface Log: as title.
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Nov 28, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some interfaces about personalization
Log: