Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: refacting DPlatformHandle to adapt treeland #291

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

18202781743
Copy link
Contributor

@18202781743 18202781743 commented Dec 17, 2024

Refact DPlatformHandle to update window settings.
Remove task dequeue in treeland interface when Personalization is inactive.
Add DTreeLandPlatformWindowHelper to manage windowContext.

pms: TASK-368399

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 17, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 17, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 17, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 18, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 18, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 18, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 19, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
@18202781743 18202781743 requested a review from zccrs December 19, 2024 08:44
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 20, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
@18202781743 18202781743 requested a review from mhduiy December 20, 2024 05:09
mhduiy
mhduiy previously approved these changes Dec 20, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 20, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 移除了多个不必要的头文件,如 "dguiapplicationhelper.h", "dplatformtheme.h", "dwindowmanagerhelper.h" 等,这有助于减少编译依赖和潜在的编译时间。
  • 删除了多个未使用的宏定义和函数,如 DEFINE_CONST_CHARresolve 等,这有助于清理代码并避免混淆。
  • 引入了新的头文件 "dplatformwindowinterface_p.h" 和 "private/dplatformwindowinterface_p.h",这表明代码结构发生了变化,可能是为了更好地组织和管理窗口接口的实现。
  • 移除了对 QWaylandWindow 的依赖,改为使用 QWindow,这可能是为了提高代码的通用性和兼容性。
  • 删除了多个未使用的类和函数,如 CreatorWindowEventFilterdPlatformWindowInterfaceByWindow 等,这有助于减少代码的复杂性和潜在的维护问题。

是否建议立即修改:

  • 是,建议立即修改以保持代码的整洁和可维护性,并确保代码的正确性和性能。

@18202781743 18202781743 requested a review from mhduiy December 23, 2024 05:05
mhduiy
mhduiy previously approved these changes Dec 24, 2024
@FeiWang1119 FeiWang1119 changed the title refact: refacting DPlatformHandle to adap treeland refact: refacting DPlatformHandle to adapt treeland Dec 24, 2024
Refacting DPlatformHandle to update window settings.
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 24, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
@kegechen
Copy link
Contributor

/approve

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit e33a394 into linuxdeepin:master Dec 24, 2024
22 of 24 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 24, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants