Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no associated soft link #57

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

myml
Copy link
Member

@myml myml commented Sep 29, 2024

玲珑支持app home机制,允许base决定app的安装位置
可以不再使用双层软链接的方式解决/app路径的问题

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myml

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myml myml force-pushed the apphome branch 2 times, most recently from 140340d to 42ed482 Compare September 29, 2024 06:54
玲珑支持app home机制,允许base决定app的安装位置
可以不再使用双层软链接的方式解决/app路径的问题
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码缩进不一致,应统一使用tab或空格进行缩进
  • 变量命名应保持一致的命名规范,例如使用下划线或驼峰命名法
  • 删除的代码块中包含了未使用的变量 DESKTOP_PATH,确认是否有遗漏
  • BIN_FILE 变量在未使用前应先检查是否已定义
  • BIN_FILE_PATH 的计算中使用了 sed 命令,但没有考虑到 BIN_FILE 可能不是绝对路径的情况
  • tee 命令的使用可能会导致文件内容的格式问题,应确保输出格式正确
  • 删除的代码块中包含了与 LINGLONG_BASE_NAMELINGLONG_BASE_VERSION 相关的变量,确认这些变量是否在其他地方被使用
  • 删除的代码块中包含了与 FLATPAK_COMMAND 相关的变量,确认这些变量是否在其他地方被使用
  • 删除的代码块中包含了与 profile 相关的变量,确认这些变量是否在其他地方被使用
  • 删除的代码块中包含了与 APPID 相关的变量,确认这些变量是否在其他地方被使用
  • 删除的代码块中包含了与 LINGLONG_APPID 相关的变量,确认这些变量是否在其他地方被使用
  • 删除的代码块中包含了与 BUILD 相关的变量,确认这些变量是否在其他地方被使用
  • 删除的代码块中包含了与 WORKDIR 相关的变量,确认这些变量是否在其他地方被使用

是否建议立即修改:

@myml myml marked this pull request as draft September 29, 2024 07:01
@myml myml changed the title feat: No associated soft link feat: no associated soft link Sep 29, 2024
@myml
Copy link
Member Author

myml commented Sep 29, 2024

需要等待 OpenAtom-Linyaps/linyaps#729 合并

@deepin-bot
Copy link

deepin-bot bot commented Nov 16, 2024

TAG Bot

New tag: 1.2.4-1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants