Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro pin non pref #127

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Fix macro pin non pref #127

merged 2 commits into from
Feb 12, 2024

Conversation

jpc-lip6
Copy link
Collaborator

Extending toward the south the I/O pin in case of layer change was the right move, but it was done too early.

We later detect that an I/O pin is usable if it is exactly ending on the abutment box, and that was no longer true.

So we do it after I/O pin detection. By the way, we add a security so we use only one of the potential output pin.

Copy link

github-actions bot commented Feb 12, 2024

A preview of is uploaded and can be seen here:

https://lip6.github.io/coriolis/pull/127/

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/lip6/coriolis/tree/gh-pages/pull/127/

@jpc-lip6 jpc-lip6 merged commit ae27d75 into main Feb 12, 2024
12 checks passed
@jpc-lip6 jpc-lip6 deleted the fix-macro-pin-non-pref branch February 12, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant