Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External-network: legacy gateway #2094

Merged
merged 1 commit into from
Oct 18, 2023
Merged

External-network: legacy gateway #2094

merged 1 commit into from
Oct 18, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Oct 18, 2023 •
edited
Loading

Description

This PR refactors the liqo-gateway in liqo-legacy-gateway

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/build

@cheina97
Copy link
Member Author

/hold

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Oct 18, 2023
@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 changed the base branch from network-external to master October 18, 2023 11:10
@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 added breaking Breaking change and removed kind/cleanup labels Oct 18, 2023
@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 requested review from fra98 and aleoli October 18, 2023 13:12
@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added merge-requested Request bot merging (automatically managed) and removed merge-requested Request bot merging (automatically managed) labels Oct 18, 2023
@cheina97 cheina97 changed the base branch from master to network-external October 18, 2023 14:52
@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/unhold

@adamjensenbot adamjensenbot removed the hold Prevent bot merging label Oct 18, 2023
@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 force-pushed the network-external branch 2 times, most recently from 3a13ba4 to 6861dad Compare October 18, 2023 16:10
@cheina97 cheina97 force-pushed the frc/legacygateway branch 2 times, most recently from 3a13ba4 to 7d66705 Compare October 18, 2023 16:17
@cheina97
Copy link
Member Author

/test

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 18, 2023
@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 18, 2023
@adamjensenbot adamjensenbot merged commit dee6d96 into liqotech:network-external Oct 18, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 18, 2023
@cheina97 cheina97 deleted the frc/legacygateway branch October 18, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
breaking Breaking change size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheina97 @adamjensenbot @aleoli @fra98