Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Offloading] Allow coexistence of podoffloadingpolicy and runtimeclass #2861

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

claudiolor
Copy link
Contributor

@claudiolor claudiolor commented Dec 10, 2024

Description

This PR introduces some changes namespace offloading mechanism allowing the podoffloadingpolicy and runtimeclass.
The Liqo runtimeclass does not need to be manually enabled anymore, and it can be used in conjunction with the pod offloading strategy and it can be used to force pods to be scheduled on virtual nodes (so on the provider clusters) independently from the pod offloading strategy.

How Has This Been Tested?

Unit test suite provided

@adamjensenbot
Copy link
Collaborator

Hi @claudiolor. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@claudiolor
Copy link
Contributor Author

/build

@claudiolor claudiolor force-pushed the clo/runtimeclass-policy branch from ce3a759 to 41b236d Compare December 10, 2024 17:44
@claudiolor claudiolor force-pushed the clo/runtimeclass-policy branch from 41b236d to d1ef847 Compare December 11, 2024 10:56
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 11, 2024
@claudiolor claudiolor force-pushed the clo/runtimeclass-policy branch 2 times, most recently from 14b1e6a to 7a6c2e5 Compare December 12, 2024 16:42
@claudiolor claudiolor changed the title [Offloading] Allow coexistence between podoffloadingpolicy and runtimeclass [Offloading] Allow coexistence of podoffloadingpolicy and runtimeclass Dec 12, 2024
@claudiolor
Copy link
Contributor Author

/build

@claudiolor
Copy link
Contributor Author

/test

@claudiolor claudiolor force-pushed the clo/runtimeclass-policy branch from 7a6c2e5 to 858609e Compare December 13, 2024 11:49
@claudiolor
Copy link
Contributor Author

/test

@claudiolor claudiolor marked this pull request as ready for review December 13, 2024 13:00
pkg/webhooks/pod/mutations.go Outdated Show resolved Hide resolved
pkg/webhooks/pod/mutations.go Outdated Show resolved Hide resolved
docs/usage/namespace-offloading.md Outdated Show resolved Hide resolved
@claudiolor claudiolor force-pushed the clo/runtimeclass-policy branch from 858609e to 36b4b26 Compare December 16, 2024 16:42
@claudiolor
Copy link
Contributor Author

/test

@fra98
Copy link
Member

fra98 commented Dec 16, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 16, 2024
@adamjensenbot adamjensenbot merged commit fdbf222 into liqotech:master Dec 16, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants