Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[virtual-kubelet] reflect pod RuntimeClass #2887

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Dec 27, 2024

Description

This PR introduces the support for pod RuntimeClass reflection.

The RuntimeClass (.spec.runtimeClassName field) is reflected from the local pod to the remote one.

If you are using the Liqo RuntimeClass, you cannot specify the RuntimeClass name as the field is already used. To overcome this problem, you can annotate the pod with liqo.io/remote-runtime-class-name: <MY_RUNTIMECLASS_NAME>.

It is also possible to enforce a remote RuntimeClass to all pods scheduled on a virtual node, by specifying it in the OffladingPatch of the virtualnode (.spec.offloadingPatch.runtimeClassName).
If you are using liqoctl to create the virtual node, you can leverage the --runtime-class-name flag.

If these options are used in combination, the following priority (from higher to lower priority) will be used to determine the remote RuntimeClass:

  1. pod Annotation (liqo.io/remote-runtime-class-name).
  2. pod RuntimeClass (.spec.runtimeClassName). It is ignored if set to liqo.
  3. virtualNode OffloadingPatch (.spec.offloadingPatch.runtimeClassName).

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the feat Adds a new feature to the codebase label Dec 27, 2024
@fra98
Copy link
Member Author

fra98 commented Dec 27, 2024

Fix #2869

@github-actions github-actions bot added the docs Updates or adds documentation label Dec 27, 2024
@fra98 fra98 force-pushed the frt/reflect-runtimeclass branch from 42ff517 to 75e0ee2 Compare January 7, 2025 11:12
@fra98 fra98 marked this pull request as ready for review January 7, 2025 11:30
@fra98 fra98 force-pushed the frt/reflect-runtimeclass branch from 75e0ee2 to 57ed78d Compare January 7, 2025 11:34
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 7, 2025
@github-actions github-actions bot added the test Adds or updates tests for the codebase label Jan 7, 2025
@fra98 fra98 force-pushed the frt/reflect-runtimeclass branch from 79f643c to 9b2e99d Compare January 8, 2025 17:07
@fra98
Copy link
Member Author

fra98 commented Jan 9, 2025

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/reflect-runtimeclass branch from 9b2e99d to 9c78286 Compare January 9, 2025 17:15
@fra98
Copy link
Member Author

fra98 commented Jan 10, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jan 10, 2025
@adamjensenbot adamjensenbot merged commit 09b5e04 into liqotech:master Jan 10, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Updates or adds documentation feat Adds a new feature to the codebase size/L test Adds or updates tests for the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants