-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[virtual-kubelet] reflect pod RuntimeClass #2887
Merged
adamjensenbot
merged 4 commits into
liqotech:master
from
fra98:frt/reflect-runtimeclass
Jan 10, 2025
Merged
[virtual-kubelet] reflect pod RuntimeClass #2887
adamjensenbot
merged 4 commits into
liqotech:master
from
fra98:frt/reflect-runtimeclass
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @fra98. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
Fix #2869 |
fra98
force-pushed
the
frt/reflect-runtimeclass
branch
from
January 7, 2025 11:12
42ff517
to
75e0ee2
Compare
fra98
force-pushed
the
frt/reflect-runtimeclass
branch
from
January 7, 2025 11:34
75e0ee2
to
57ed78d
Compare
fra98
force-pushed
the
frt/reflect-runtimeclass
branch
from
January 8, 2025 17:07
79f643c
to
9b2e99d
Compare
aleoli
approved these changes
Jan 9, 2025
/rebase test=true |
adamjensenbot
force-pushed
the
frt/reflect-runtimeclass
branch
from
January 9, 2025 17:15
9b2e99d
to
9c78286
Compare
/merge |
adamjensenbot
added
the
merge-requested
Request bot merging (automatically managed)
label
Jan 10, 2025
adamjensenbot
removed
the
merge-requested
Request bot merging (automatically managed)
label
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the support for pod RuntimeClass reflection.
The RuntimeClass (
.spec.runtimeClassName
field) is reflected from the local pod to the remote one.If you are using the Liqo RuntimeClass, you cannot specify the RuntimeClass name as the field is already used. To overcome this problem, you can annotate the pod with
liqo.io/remote-runtime-class-name: <MY_RUNTIMECLASS_NAME>
.It is also possible to enforce a remote RuntimeClass to all pods scheduled on a virtual node, by specifying it in the OffladingPatch of the virtualnode (
.spec.offloadingPatch.runtimeClassName
).If you are using liqoctl to create the virtual node, you can leverage the
--runtime-class-name
flag.If these options are used in combination, the following priority (from higher to lower priority) will be used to determine the remote RuntimeClass:
liqo.io/remote-runtime-class-name
)..spec.runtimeClassName
). It is ignored if set toliqo
..spec.offloadingPatch.runtimeClassName
).