Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update common.sh #2891

Closed
wants to merge 1 commit into from
Closed

Update common.sh #2891

wants to merge 1 commit into from

Conversation

yigitpolat
Copy link

Description

I had the following prompt while trying to spin up the quickstart clusters.

$ cd liqo/examples/global-ingress
$ ./setup.sh
SUCCESS	No cluster "edgedns" is running.
SUCCESS	No cluster "gslb-eu" is running.
SUCCESS	No cluster "gslb-us" is running.
SUCCESS	Cluster "edgedns" has been created.
SUCCESS	Cluster "gslb-eu" has been created.
SUCCESS	Cluster "gslb-us" has been created.
SUCCESS	Bind server has been deployed.
SUCCESS	K8gb has been installed on cluster.
SUCCESS	Ingress-nginx has been installed on cluster.
INFO	Installing liqo on cluster "gslb-eu"...
ERROR	Failed to install liqo on cluster "gslb-eu": Error: unknown flag: --cluster-id

Looks like --cluster-id is no longer a valid flag. Fixing it in the script

Fixes #(issue)

How Has This Been Tested?

After the changes, the clusters are available to test.

$ ./setup.sh
SUCCESS	No cluster "edgedns" is running.
SUCCESS	No cluster "gslb-eu" is running.
SUCCESS	No cluster "gslb-us" is running.
SUCCESS	Cluster "edgedns" has been created.
SUCCESS	Cluster "gslb-eu" has been created.
SUCCESS	Cluster "gslb-us" has been created.
SUCCESS	Bind server has been deployed.
SUCCESS	K8gb has been installed on cluster.
SUCCESS	Ingress-nginx has been installed on cluster.
SUCCESS	Liqo has been installed on cluster "gslb-eu".
SUCCESS	K8gb has been installed on cluster.
SUCCESS	Ingress-nginx has been installed on cluster.
SUCCESS	Liqo has been installed on cluster "gslb-us".

@adamjensenbot
Copy link
Collaborator

Hi @yigitpolat. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@claudiolor
Copy link
Contributor

Hi @yigitpolat, thanks for opening this PR.

The --cluster-id flag is actually still valid in the latest version of liqoctl while from version 1.0, the --cluster-name flag has been removed.
I believe you are running a previous version liqoctl (0.10.3 or below), which doesn't work with quick-start examples in the master branch.
To install the latest version of liqoctl you can check the documentation in this page.

I'm going to close this PR, but we really appreciate your contributions. If you need any help or support please do not hesitate to open an issue or reach us via the Liqo Slack workspace.

@claudiolor claudiolor closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants