Fixes class map truncation #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue with how the class maps were being built up. When there are a certain number of classes extracted from a template they could exceed Elixir's own truncation limit when it comes to stringifying. Typically this can be worked around by setting an
:infinitylimit but in this case the code was usingMacro.to_string/1. The quoted code being passed toMacro.to_stringwas directly printing the entire list of classes.This was going to present sooner or later. Glad we found it now. This PR fixes it but is not a permanent fix. Instead of injecting the literal array into the code it will cache it in Ets and retrieve at runtime for the function avoiding the truncation issue of the AST being evaluated.