Test & solution for #59 (MERGE CONFLICTS RESOLVED) #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjlim5
requested changes
Jun 15, 2017
| if(num === 1 || num === 0 || num === -1){ | ||
| return false; | ||
| } | ||
| for(let i = 2; i < Math.sqrt(num); i++){ |
There was a problem hiding this comment.
When using a specific algorithm that may not be known to general audience, it is good practice to leave a comment explaining the algorithm. In this case, the comment can say Trial division test for Primality: divide from 2 to the square root of the number
yjlim5
reviewed
Jun 15, 2017
| @@ -19,6 +21,20 @@ const solution = (num) => { | |||
| } | |||
| return true; | |||
| }; | |||
|
|
|||
| const solution1 = (num) => { | |||
| if(num === 1 || num === 0 || num === -1){ | |||
There was a problem hiding this comment.
Could you rewrite this condition so that it can handle num like -2? or -3452?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.