Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution and test for problem #14 #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions solutions/14.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Rahul Kalra
// Return an array of the diagnal values starting from 0,0 from a 2D array input(gauranteed to be square).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write proper comments, like here: https://github.com/llipio/algorithms/pull/75/files

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkalra247, please make sure there is no typo in comment, and add comments like this: https://github.com/llipio/algorithms/pull/55/files


const solution = (array) =>{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use array as a variable name. call it input

let newArray = [];

for(let i = 0; i < array.length; i++){
for(let j = 0; j < array.length; j++){
if(i === j){
newArray.push(array[i][j]);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

}
}
return newArray;
};

module.exports = {solution};
8 changes: 8 additions & 0 deletions test/14.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
let expect = require('chai').expect;
let solution = require('../solutions/14').solution;

describe('Diagonal Array', () => {
it('should return an array of diagonal values', () => {
expect(solution([[1,2,3],[2,3,4],[3,4,5]])).to.eql([1,3,5]);
});
});