Scaffold v2 #1209
Open
Scaffold v2 #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondot
approved these changes
Jan 23, 2025
| @@ -0,0 +1,379 @@ | |||
| use std::collections::HashMap; | |||
There was a problem hiding this comment.
if this file is just about helpers for views (scaffold etc) i would call it tera_scaffold_ext.rs
if its general extensions then:
tera_ext.rs
it's ok to name our engine explicitly (tera) just for the purpose of finding exactly what you're looking for "where is this tera builtin coming from? ah, tera_ext.rs"
| <div class="relative flex min-h-screen flex-col bg-background"> | ||
| <div class="themes-wrapper bg-background"> | ||
| <div style="--sidebar-width:16rem;--sidebar-width-icon:3rem" class="group/sidebar-wrapper flex min-h-svh w-full has-[[data-variant=inset]]:bg-sidebar"> | ||
| <main class="relative flex min-h-svh flex-1 flex-col bg-background peer-data-[variant=inset]:min-h-[calc(100svh-theme(spacing.4))] md:peer-data-[variant=inset]:m-2 md:peer-data-[state=collapsed]:peer-data-[variant=inset]:ml-2 md:peer-data-[variant=inset]:ml-0 md:peer-data-[variant=inset]:rounded-xl md:peer-data-[variant=inset]:shadow"> |
There was a problem hiding this comment.
in the context of a "fresh" scaffold file, tailwind classes make it a very unhappy place to edit
can we create custom classes in our own CSS (or maybe in base) and use a single class in the different view files?
| ("uuid", "uuid_uniq"), | ||
| ("uuid_col", "uuid_null"), | ||
| ("uuid_col!", "uuid"), | ||
| ("uuid^", "uuid_uniq"), |
There was a problem hiding this comment.
maybe add a special doc about the new array types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the scaffold generator and prepares for a shell UI with registration, login, and logout.