Fix issue where empty WebUI property is not parsed correctly #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @timhovius! Thanks for reporting and fixing this issue! If you have time, it would be great if you could also add a test case for this scenario? |
|
Hi @timhovius ! Have you had any chance to look at making a test for this? |
Yes I'm looking into this currently. |
|
Actually it goes wrong when no default value was set. So I modified the tests to test this behavior and I added an extra test. |
| data={"user_count": 1, "spawn_rate": 1, "host": "", "my_argument": "42"}, | ||
| ) | ||
| self.assertEqual(200, response.status_code) | ||
| self.assertEqual(42, my_dict["val"]) |
There was a problem hiding this comment.
Nice! Thanks for adding tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3011