chore: add golangci-lint as linter

[mavogel]

Description

Adds golangci-lint as linter, with Makefile target and GH action.
We could fixe all the issues and/or disable certain linters on the way: @maxekman WDYT?

Affected Components

• all

Related Issues

#199

Steps to test and verify

1. make setup
2. make lint

[maxekman]

Looks interesting! Will take a look soon.

[coveralls]

Coverage increased (+0.1%) to 69.231% when pulling 1fa17e8 on mavogel:chore/add-linter into a155912 on looplab:main.

[maxekman]

Great suggestions with linting! I added some comments/questions.

[maxekman]

@mavogel Did you have time to read my comments?

[mavogel]

Yes, @maxekman. I'll pick it up this week :)

[mavogel]

Feel free to resolve the conversations and let discuss how we continue. As my terminal cannot capture all errors, I stored them temporarily into lint.txt go give an overview. I'll delete it later. Most probably it makes sense to deactivate linters such as

• gochecknoinits
• godox
• exhaustivestruct
• and scopelint

at local points for not changing the code too much in the first iteration. And from then on remove step by step those linters in future PRs. WDYT?

[maxekman]

Nice work! 👌

I’ll go through the errors in the coming week and try to guess what level of linting/ignores is appropriate for the project.

[maxekman]

I addad some notes on step naming to be changed be fore merging. I still need to go through the linting errors and decide what to fix etc.

[maxekman]

Would it be possible for you to separate out the Makefile command for linting so that appropriate linting settings and fixing linting errors can be done before activating the CI linting?

[maxekman]

Very useful! 👍

[maxekman]

@mavogel The project will be ready to use the CI config for the linter after #349 and #348 is merged.