[orchestrator] fix bugs in orchestrator.py script #25873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfrantz
approved these changes
Jan 14, 2025
moidx
approved these changes
Jan 14, 2025
timothytrippel
force-pushed
the
fix-orchestrator-bug
branch
3 times, most recently
from
2a3c01b to
41b6e30
Compare
This fixes a bug in the computation and construction of the Device ID when parts are provisioned from a TestLocked* stage, i.e., if part has already previously run through CP and then runs through FT at a later stage. In this scenario, the there is no CP device ID returned to the Host (since CP stage is not run), so FT must trust what already exists in flash, and the final device ID is read out by the host over JTAG at the end of provisioning. Signed-off-by: Tim Trippel <[email protected]>
timothytrippel
force-pushed
the
fix-orchestrator-bug
branch
from
41b6e30 to
bb137d2
Compare
There are two potential usecases of the orchestrator.py script: 1. to run both CP and FT flows in the same script execution at the same secure facility, or 2. to run the CP stage in one script execution (at one secure facility), and the FT stage in a subsequent script execution (at a different secure facility). The first flow was already covered by the e2e_test, however the second flow was not. This adds another test, e2e_multistage_test, to cover the second flow. Signed-off-by: Tim Trippel <[email protected]>
This updates the orchestrator to check if a device ID already exists in the database before attempting to update the entry. Signed-off-by: Tim Trippel <[email protected]>
timothytrippel
force-pushed
the
fix-orchestrator-bug
branch
from
bb137d2 to
5b81ae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in the orchestrator.py script:
Additionally, this enhances the E2E testing of the orchestrator.py script catch these corner cases.