[toolchain] Make Os and Oz mutually exclusive. #25928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures optimization level flags are exclusive, resolving ambiguity caused by the previous implementation where it expects the last flag overwrote the optimization level. Change-Id: I6b372c36ac99eb647f36956934e08fd6cc0e412f Signed-off-by: Yi-Hsuan Deng <[email protected]>
jwnrt
approved these changes
Jan 17, 2025
timothytrippel
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures optimization level flags are exclusive, resolving ambiguity caused by the previous implementation where it expects the last flag overwrote the optimization level.
Verified with
--subcommandsthat Oz is the only one -O flag when building rom exts, while other tests are built with Os.