Development: Fix an issue with LTI authorization types

[krusche]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
• I strictly followed the principle of data economy for all database calls.
• I strictly followed the server coding and design guidelines.

Motivation and Context

Fix an issue with authorization types in LTI and make the code more robust with records

Steps for Testing

Prerequisites:

• 1 Student

1. Log in to Artemis via Moodle and LTI

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

• Code Review 1

Manual Tests

• Test 1

[raffifasaro]

Tested on TS1, authorization works again

[coderabbitai]

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between b26821c and 1c65c8a.

📒 Files selected for processing (18)

• src/main/java/de/tum/cit/aet/artemis/communication/dto/ChannelDTO.java (1 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/config/Lti13LaunchFilter.java (2 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/dto/Claims.java (1 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/dto/Lti13AgsClaim.java (1 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/dto/Lti13AuthenticationResponse.java (1 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/dto/Lti13ClientRegistration.java (1 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/dto/Lti13ClientRegistrationFactory.java (1 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/dto/Lti13DeepLinkingResponse.java (2 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/dto/Lti13LaunchRequest.java (2 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/dto/Lti13Message.java (1 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/dto/Lti13PlatformConfiguration.java (2 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/dto/Lti13ToolConfiguration.java (1 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/service/LtiDynamicRegistrationService.java (4 hunks)
• src/main/java/de/tum/cit/aet/artemis/lti/service/OnlineCourseConfigurationService.java (2 hunks)
• src/test/java/de/tum/cit/aet/artemis/core/security/lti/Lti13LaunchFilterTest.java (3 hunks)
• src/test/java/de/tum/cit/aet/artemis/core/security/lti/Lti13TokenRetrieverTest.java (2 hunks)
• src/test/java/de/tum/cit/aet/artemis/lti/LtiDynamicRegistrationServiceTest.java (3 hunks)
• src/test/java/de/tum/cit/aet/artemis/lti/service/OnlineCourseConfigurationServiceTest.java (2 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[raffifasaro]

re-approve