Athena: Improve AI feedback request validation

[maximiliansoelch]

Warning

Only deploy to TS1 for now, as Athena currently does not work on TS2 and TS3

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
• I strictly followed the principle of data economy for all database calls.
• I strictly followed the server coding and design guidelines.
• I added multiple integration tests (Spring) related to the features (with a high test coverage).
• I documented the Java code using JavaDoc style.

Client

• I strictly followed the client coding and design guidelines.
• I translated all newly inserted strings into English and German.

Motivation and Context

Currently, there are some issues with the AI feedback request feature:

1. It is possible to request feedback despite no submission was yet made by the student. The check for this case is wrong, as it assumes that no submission will be present in the database. However, if a student starts the exercise, the submission is already created in the database.
2. The server does not check if the submission is empty before sending it to Athena, which results in an unspecific error message. This only affects text exercises, as there is a client-side check so that a student can not submit an empty modeling submission.
3. There is an issue with the german translation key submissionAlreadyHasAthenaResult: "Bitte reiche eine neue Abgabe ein, bevor du erneut einreichst.", which is incorrect.

In addition, all AI Feedback request services for the different exercise types have their own implementation for checking the request rate limit, which causes code duplication and is hard to maintain.

Description

This PR fixes several issues and reduces code duplication for the request AI feedback feature:

1. The check was improved and now checks if there exists at least one successful submission in the database.
2. A check was added that allows AI feedback requests only for nonempty text and modeling submissions. Translation keys for the corresponding error message were added.
3. The translation was corrected.

Steps for Testing

Prerequisites:

• 1 Students
• 1 Text Exercise with Athena Feedback Requests enabled
• 1 Modeling Exercise with Athena Feedback Requests enabled

1. Testcase: Request Feedback without a successful submission
Do these steps for each exercise type:

1. Start the exercise
2. Open your browser's developer tools and remove the disabled keyword from the request feedback button
3. Click on the now enabled request feedback button on the exercise overview page
4. There should be an error message that you first need to submit

2. Testcase: Request Feedback on an empty text submission

1. Click on the text exercise to work on it
2. Leave the submission text empty and just submit it
3. Request feedback should now throw an error message

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Performance Tests

• Test 1
• Test 2

Test Coverage

Screenshots

[EneaGore]

Code lgtm and both rate limits and previous feedback checks worked as expected on TS1.