-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Upgrade to Spring Boot 3, Spring 6, Hibernate 6
#7719
Conversation
# Conflicts: # src/main/java/de/tum/in/www1/artemis/domain/quiz/DragAndDropQuestion.java # src/test/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseFeedbackCreationServiceTest.java
- join column defined in collection table - element collection always cascading
See #8256 . We need to retrieve all users that belong to no course because we have to delete them on a regular basis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions, see my comments. it would be nice if you could directly remove the star imports instead of renaming them, as we agreed in the dev team that we don't want to use them anymore.
src/main/java/de/tum/in/www1/artemis/config/SAML2Configuration.java
Outdated
Show resolved
Hide resolved
...va/de/tum/in/www1/artemis/repository/SolutionProgrammingExerciseParticipationRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/connectors/iris/IrisConnectorService.java
Show resolved
Hide resolved
As discussed in the issue, I readded the capability to get users that have no user group. I also updated the description accordingly. However, implementing this in the client is out of scope for this PR. |
@reschandreas As discussed via DMs, I'd like to not include larger import changes in this PR to prevent bloating. We can do this in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a high priority PR and we would like to merge it into
develop
until end of March. Please help with testing and reviewing!Changelog
SQL Dialects
PostgreSQL10Dialect
. Replace the dialect in your config with thePostgreSQLDialect
of of the same package.MySQL8Dialect
. Replace the dialect in your config with theMySQLDialect
of the same package.Configuration
hibernate.dialect
is deprecated and can be removed. The specified JDBC URL will select the dialectChecklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
Upgrading Spring Boot to major version 3
Description
javax
imports withjakarta
importsjavax
importsDELETE FROM user_groups g WHERE NOT EXISTS (SELECT * FROM course c WHERE c.student_group_name = g OR c.teaching_assistant_group_name = g OR c.editor_group_name OR c.instructor_group_name);
)Steps for Testing
The whole application requires testing. Please refer to your specific testing instructions during a testing session or pick an area of your choosing and investigate it.
Exam Mode Testing
The whole application requires testing. Please refer to your specific testing instructions during a testing session or pick an area of your choosing and investigate it.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
Omitted. No real functional changes and listing the test results for all files touched would take ages. It's a unique PR and hence reasonable.