-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Improve performance of overview page
#7826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
server
Pull requests that update Java code. (Added Automatically!)
client
Pull requests that update TypeScript code. (Added Automatically!)
labels
Dec 27, 2023
bassner
temporarily deployed
to
artemis-test1.artemis.cit.tum.de
December 28, 2023 20:41 — with
GitHub Actions
Inactive
bassner
temporarily deployed
to
artemis-test2.artemis.cit.tum.de
December 28, 2023 20:47 — with
GitHub Actions
Inactive
bassner
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and on TS2, looks good so far
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Pull requests that update TypeScript code. (Added Automatically!)
ready for review
server
Pull requests that update Java code. (Added Automatically!)
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Client
Motivation and Context
We're sending too much data in the for-dashboard call of the overview page that is not needed.
Description
Removed fields from the transmitted courses that are not relevant. Active exams are now added separately so we can still display active exams on top.
Steps for Testing
Prerequisites:
Review Progress
Performance Review
Code Review
Manual Tests