Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Improve performance of overview page #7826

Merged
merged 6 commits into from
Dec 29, 2023

Conversation

krusche
Copy link
Member

@krusche krusche commented Dec 27, 2023

Checklist

General

  • I tested all changes and their related features with all corresponding user types on a test server.
  • This is a small issue that I tested locally and was confirmed by another developer on a test server.
  • I chose a title conforming to the naming conventions for pull requests.

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.

Motivation and Context

We're sending too much data in the for-dashboard call of the overview page that is not needed.

Description

Removed fields from the transmitted courses that are not relevant. Active exams are now added separately so we can still display active exams on top.

Steps for Testing

Prerequisites:

  • 1 Student
  1. Log in to Artemis
  2. Click into one course
  3. Make sure all data is displayed correctly

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1

Manual Tests

  • Test 1

@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) labels Dec 27, 2023
Copy link
Member

@bassner bassner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and on TS2, looks good so far

@krusche krusche added this to the 6.7.4 milestone Dec 28, 2023
@bassner bassner marked this pull request as ready for review December 29, 2023 10:01
@bassner bassner requested a review from a team as a code owner December 29, 2023 10:01
@bassner bassner merged commit ea888b2 into develop Dec 29, 2023
61 of 66 checks passed
@bassner bassner deleted the performance/improve-dashboard-calls branch December 29, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready for review server Pull requests that update Java code. (Added Automatically!) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants