Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Remove eager relationship between team and students #7829

Merged
merged 29 commits into from
Jan 18, 2024

Merge branch 'develop' into chore/remove-team-eager

4bf2fe2
Select commit
Loading
Failed to load commit list.
Merged

Development: Remove eager relationship between team and students #7829

Merge branch 'develop' into chore/remove-team-eager
4bf2fe2
Select commit
Loading
Failed to load commit list.
Teamscale / teamscale-findings required action Jan 18, 2024 in 0s

Teamscale

This pull request would introduce 9 new findings

Details

Teamscale's logo 9 added, 24 in changed code, 4 removed 31 Test Gaps (100%) tested changes: 0|untested changes: 26|untested additions: 5

  • src/main/java/de/tum/in/www1/artemis/web/rest/ComplaintResource.java#188: Avoid using ternary operators (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseStudentParticipationRepository.java#170: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseStudentParticipationRepository.java#115: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/repository/TeamRepository.java#33: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/repository/ProgrammingSubmissionRepository.java#49: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseStudentParticipationRepository.java#159: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/repository/TeamRepository.java#134: Interface comment missing (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/exercise/modelingexercise/compass/umlmodel/AbstractUMLDiagramTest.java#23: TODO: we should not mock like this! (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/service/ParticipationAuthorizationCheckService.java#9: Star import of de.tum.in.www1.artemis.domain.* should not be used (view in Teamscale)