Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Improve integration of Monaco code editor and Athena Preliminary Feedback #9778

Draft
wants to merge 11 commits into
base: feature/programming-exercises/choose-preliminary-feedback-model
Choose a base branch
from

Conversation

dmytropolityka
Copy link
Contributor

@dmytropolityka dmytropolityka commented Nov 14, 2024

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
  • I strictly followed the principle of data economy for all database calls.
  • I strictly followed the server coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

  • High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).
  • I tested all changes and their related features with all corresponding user types on a test server configured with Gitlab and Jenkins.

Motivation and Context

This PR addresses the need for better feedback handling in the code editor for programming exercises. It improves the feedback refresh mechanism and introduces a feature to reopen closed feedback directly from the file tree. These changes enhance usability and provide instructors and students with a more streamlined feedback experience.

Description

This PR introduces enhancements to the feedback management system in the programming exercise code editor. It focuses on improving the user experience when working with feedback items by implementing a feedback refresh mechanism and adding a "Reopen Feedback" button in the file tree. The changes aim to provide a more intuitive and seamless workflow for managing feedback, particularly during active programming assignments.

Steps for Testing

Prerequisites
1 Instructor
1 Student

A programming exercise with feedback enabled.
Testing Feedback Updates in the Programming Editor

  1. Log in to Artemis.
  2. Navigate to the programming exercise [link to exercise].
  3. Open the code editor for the exercise.
  4. Submit a change to the repository.
  5. Request feedback.

Verify that:

  1. Feedback updates are reflected in real-time in the code editor.
  2. The correct number of feedback badges appears in the file tree next to the relevant files.
  3. Close one or more feedback items.
  4. Use the "Reopen Feedback" button in the file tree to restore the closed feedback.
  5. Confirm that the feedback is restored in the code editor and matches the count indicated in the file tree.

Testing in Exam Mode

  1. Create or navigate to an exam with a programming exercise.
  2. Participate as a student.
    Verify that:
  3. The "Reopen Feedback" button and other related features are not accessible in exam mode.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Performance Tests

  • Test 1
  • Test 2

Screenshots

image
image

@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) programming Pull requests that affect the corresponding module labels Nov 14, 2024
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 21, 2024
@dmytropolityka dmytropolityka changed the title Programming exercises: improve integration of Monaco code editor and Athena Preliminary Feedback Programming exercises: Improve integration of Monaco code editor and Athena Preliminary Feedback Dec 3, 2024
@dmytropolityka dmytropolityka changed the title Programming exercises: Improve integration of Monaco code editor and Athena Preliminary Feedback Programming exercises: Improve integration of Monaco code editor and Athena Preliminary Feedback Dec 3, 2024
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 11, 2024
…ck-model' into feature/programming-exercises/athena-feedback-in-code-editor

# Conflicts:
#	src/main/java/de/tum/cit/aet/artemis/programming/service/ProgrammingExerciseCodeReviewFeedbackService.java
#	src/main/webapp/app/exercises/programming/participate/code-editor-student-container.component.html
#	src/main/webapp/app/exercises/programming/participate/code-editor-student-container.component.ts
#	src/main/webapp/app/exercises/shared/result/updating-result.component.ts
…ck-model' into feature/programming-exercises/athena-feedback-in-code-editor
@github-actions github-actions bot added database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. athena Pull requests that affect the corresponding module core Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module modeling Pull requests that affect the corresponding module text Pull requests that affect the corresponding module labels Jan 5, 2025
@dmytropolityka dmytropolityka changed the base branch from develop to feature/programming-exercises/choose-preliminary-feedback-model January 6, 2025 00:33
@github-actions github-actions bot removed athena Pull requests that affect the corresponding module core Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module modeling Pull requests that affect the corresponding module text Pull requests that affect the corresponding module labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. deployment-error Added by deployment workflows if an error occured programming Pull requests that affect the corresponding module server Pull requests that update Java code. (Added Automatically!) tests
Projects
Status: Work In Progress
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant