Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Timeframe Parameter Consistency on Navigation #189

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

GODrums
Copy link
Collaborator

@GODrums GODrums commented Nov 25, 2024

Motivation

Fixes a bug where the timeframe parameters assumed invalid states on browser tab change or same page-navigation, i.e. when clicking on the logo in the header.

Description

This PR is a follow-up to #188 and fixes:

  • after/before-param consistency in the URL:
    • when switching tabs
    • when navigating on the same page (e.g. removing query params without changing the page -> revelant for Hephaestus-logo in header) go back to default timeframe (i.e. current week)
  • remove state logic from home component and move to timeframe component
  • incorrect time ranges in current week ("Custom Range") - now uses the actual end date of the week instead of current minute

Testing Instructions

  • Run application-server and webapp
  • Navigate through different leaderboards
  • Use the Hephaestus-Logo and check if you get navigated back to the default leaderboard
  • Go to a different browser tab and back (state should stay the same)
  • Leave the leaderboard open for a few minutes and check if the state stays valid after switching timeframes back and worth

Screenshots (if applicable)

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

@GODrums GODrums added bug Something isn't working client priority:critical Urgent tasks needing immediate resolution. labels Nov 25, 2024
@GODrums GODrums self-assigned this Nov 25, 2024
@github-actions github-actions bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 25, 2024
@FelixTJDietrich FelixTJDietrich merged commit db7f35e into develop Nov 25, 2024
5 checks passed
@FelixTJDietrich FelixTJDietrich deleted the fix/leaderboard-timeframe-navigation branch November 25, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client priority:critical Urgent tasks needing immediate resolution. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants