Refactor
: Modularization of Task Scheduling
#194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For future features (such as the leaderboard leagues) we need to be able to execute tasks easily at the end of each leaderboard cycle.
Implements task 3.1 of #170.
Description
This PR reworks the original task scheduler used for the weekly Slack message to be more modular (separating the logic) and easily support adding new tasks:
LeaderboardTaskScheduler
now manages all tasks and schedules them for the end of a leaderboard cycleSlackMessageService
is now only a light wrapper around theSlackAppConfig
, providing implementations for sending messages and testing the connectionSlackWeeklyLeaderboardTask
is a runnable task, scheduled by theLeaderboardTaskScheduler
, responsible for creating the Slack message and delegating the sending processTesting Instructions
No manual testing required - Code reviews would be great though!
Would love to receive feedback on:
Checklist
General
Server (if applicable)