Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Persist User Change on Navigation #209

Conversation

GODrums
Copy link
Collaborator

@GODrums GODrums commented Dec 8, 2024

Motivation

Fixes #208.

Description

This fix makes sure profile pages listen to URL changes.

Testing Instructions

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

@GODrums GODrums added bug Something isn't working client labels Dec 8, 2024
@GODrums GODrums self-assigned this Dec 8, 2024
@GODrums GODrums linked an issue Dec 8, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 8, 2024
Copy link
Contributor

@milesha milesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works just right! 👍🏼

Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me, thanks for the fix!

@FelixTJDietrich FelixTJDietrich merged commit 1234671 into develop Dec 8, 2024
4 checks passed
@FelixTJDietrich FelixTJDietrich deleted the 208-profile-redirection-issue-no-automatic-redirect-on-my-profile-click branch December 8, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Redirection Issue: No Automatic Redirect on 'My Profile' Click
3 participants