Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required validation for file is not executed closes #1737 and closes #1128 and closes #1738 #1739

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kchobantonov
Copy link

All Submissions:

  • [x ] Have you followed the guidelines in our Contributing document?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you written unit tests?
  • [x ] Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • [ x] This PR is associated with an existing issue?

Closing issues

closes #1737
closes #1128
closes #1738

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there kchobantonov 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@kchobantonov
Copy link
Author

@WoH please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant