Fix shader ERROR: 0:155: 'isPerspectiveMatrix' : no matching overloaded function found #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14.
See related issue above.
I am not sure why, but I was only able to reproduce the problem in a larger project of ours where we use a lot of typescript files with Three.JS + esbuild. I tried to reproduce in a small test Three.js project with typescript and esbuild but I could not reproduce it...
Either way, I found the following OLD GH issue on the original MeshLine project for this very issue spite#123
The fix is rather simple, adding the
#include <common>
line to the top of the vertex shader solves the issue. Even if no issue ever was, I don't think this introduces anything but benefits? Correct me if I am wrong. At least it solves our problem.Currently we are working around this with the following code:
Could this finally be merged to this fork? It was seemingly never merged in the original before the project died.