Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerfile and updated README #135

Closed
wants to merge 4 commits into from
Closed

Added dockerfile and updated README #135

wants to merge 4 commits into from

Conversation

MartinTerp
Copy link

No description provided.

@MartinTerp
Copy link
Author

Its also hosed on docker hub: https://hub.docker.com/r/terpz/pokete
but i think you should be the one to create the real one, maybe with auto build from git.

Copy link
Collaborator

@MaFeLP MaFeLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

Other publishing methods have been standing on our To-Do List for at least a couple of months!

Please just add a .dockerignore file, containing the directories .git and __pycache__, as these directories are getting the image size WAAAY up.

After that, I think we are ready to merge!

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MaFeLP
Copy link
Collaborator

MaFeLP commented Jun 11, 2022

Thanks for the docker hub idea. If you want, you could also contribute the GitHub Action to push to ghcr.io and docker hub. If not, I would look into it in the next coming days/weeks.

@MaFeLP MaFeLP added the enhancement New feature or request label Jun 11, 2022
@MaFeLP MaFeLP requested a review from lxgr-linux June 11, 2022 21:30
@MartinTerp
Copy link
Author

Seems fair, regardin the version and the debian image.
I just wanted to make sure that i was in 100% control that it woudnt break anything, but the minor verions was overkill, i will give you that, and the debian was just the "goto" image for me, but it makes sense to use alpine in this case.

Eventhough im against the symlink in the dockerfile (just think it looks ugly ;) ) im willing to make an exception ^^

@MartinTerp MartinTerp requested a review from MaFeLP June 18, 2022 14:25

WORKDIR /usr/src/app

RUN pip install --no-cache-dir scrap_engine && \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN pip install --no-cache-dir scrap_engine && \
RUN pip install --no-cache-dir scrap_engine playsound pygobject && \

I would suggest adding those two dependencies, which have been added with the Sound PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wont build, because it needs libs and compilers in the image.
I will see what i can do, hopefully i can do some magic with multistage dockerbuild

Copy link

@AVoSI-VI AVoSI-VI Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can build your container like so and save about 275MB~ over a non-multistage image:

FROM alpine:3.15 AS compile-image

RUN apk add \
    python3-dev \
    py3-pip \
    py3-gst \
    gobject-introspection-dev \
    cairo-dev \
    build-base 

RUN python3 -m pip install --user scrap_engine playsound pygobject 

From alpine:3.15

RUN apk add --no-cache \
    python3-dev \
    py3-gst 
    
COPY --from=compile-image /root/.local /root/.local
ENV PATH="/root/.local/bin:$PATH"

RUN mkdir -p /root/.cache/pokete && \
    ln -s /root/.cache/pokete /data

COPY . .

VOLUME ["/data"]

CMD [ "python", "./pokete.py" ]

@MaFeLP MaFeLP mentioned this pull request Jun 19, 2022
12 tasks
MaFeLP added a commit that referenced this pull request Jul 21, 2022
Added the dockerfile from pull request #135, as there seems to be no
more work being done on it.

Currently sound does not work with docker.

Co-authored-by: MartinTerp <[email protected]>
Co-authored-by: Victim <94010769+anothervictimofsurvivalinstinct@users.noreply.github.com>
@MaFeLP
Copy link
Collaborator

MaFeLP commented Jul 21, 2022

As there has been no activity in the last month, the Dockerfile as proposed by @anothervictimofsurvivalinstinct has been added to #195 in 1ec9c5b. This pull request will therefore be closed.

@MaFeLP MaFeLP closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants