-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lxqt-transupdate to update translations in cmake #38
base: master
Are you sure you want to change the base?
Conversation
Removed not needed code Removed Qt4 support
if (TR_UPDATE_TRANSLATIONS) | ||
message("Running lxqt-transupdate: ") | ||
execute_process( | ||
COMMAND lxqt-transupdate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should change the logic of getting sources and ts files in lxqt-transupdate
and use here the ${TR_SOURCES}
and ${tsFiles}
.... so the configuration is exactly on one place (not in CMakeLists.txt
together with .translation-update
)
@palinek - i'm not convinced - it would make sense the other way round. To be verbose of: I don't see any sense in any cmake magic here - you might see it different. But .translation-update is exactly the scheme that is used in weblate too. So please see .translation-update as a kind of documentation. Might sound crazy, but isn't - let's use .translation-update as a single point of failure. We will notice it if something goes wrong here very fast. The point is: If we change some translation directories (moving or renaming paths) this will break weblate too. So i would like it to fail in cmake too. That would be great. |
@agaida Is this PR still valid ? |
I think this is not a good idea anymore, it would need always committing all pending translations in weblate first. Now always before running lxqt-transupdate it is mandatory to
Run it, commit and merge it and only after that unlock weblate component. Otherwise there will be rebase issues in weblate, |
FWIW I hope to see |
Removed not needed code
Removed Qt4 support
supersedes /pull/36