Skip to content

Commit

Permalink
noted TODO: current deploy checkrun is updated twice on confirm/rejec…
Browse files Browse the repository at this point in the history
…t apply (once with empty Result, once with Result filled in
  • Loading branch information
tlin4194 committed Nov 7, 2024
1 parent c921b26 commit d5ef226
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func (n *StateReceiver) Receive(ctx workflow.Context, c workflow.ReceiveChannel,
}
}
// Updates github check run with Terraform statuses for the current running deployment
// TODO: do not notify github if workflowState.Result.Status == InProgressWorkflowStatus && workflowState.Result.Reason == UnknownCompletionReason
for _, notifier := range n.InternalNotifiers {
if err := notifier.Notify(ctx, deploymentInfo.ToInternalInfo(), workflowState); err != nil {
workflow.GetMetricsHandler(ctx).Counter("notifier_failure").Inc(1)
Expand Down

0 comments on commit d5ef226

Please sign in to comment.