Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Refactor workflows to use new layout and spacing units #3156

Closed
wants to merge 9 commits into from

Conversation

septum
Copy link
Contributor

@septum septum commented Oct 23, 2024

Description

  • Modified the configuration and component of all routes of every workflow to use new layout and spacing units

Screenshots

Standard Layout

Before

clutch lyft net_catalog_ (1)

After

localhost_3000_ec2_asg_resize (2)

Note

New props were added to the layout to display only the breadcrumbs and preserve previous route component header

Wizard Layout

Before

clutch lyft net_dash_ (1)

After

379093432-227ce42a-f890-4889-8860-e7c6c27c929f

Custom Layout

Before

clutch lyft net_dash_

After

localhost_3000_dash

Testing Performed

Manual

TODO

  • Change the application of spacing units to rely on the Clutch spacing

@septum septum requested a review from a team as a code owner October 23, 2024 04:02
Base automatically changed from adjust-workflow-layout-whitespace to main October 23, 2024 18:04
Copy link
Contributor

@jdslaugh jdslaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, lets see if we can break up this PR into 2 so that we can reduce the scope that this one impacts.

frontend/workflows/audit/src/index.tsx Show resolved Hide resolved
layoutProps: {
variant: "standard",
title: "Project Catalog",
subtitle: "A catalog of all projects.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just utilize the description versus a secondary subtitle?

@septum septum closed this Oct 28, 2024
@septum septum deleted the workflow-layout-refactoring branch October 28, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants