Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Merge from kubeflow/katib #13

Open
wants to merge 1,253 commits into
base: master
Choose a base branch
from
Open

Merge from kubeflow/katib #13

wants to merge 1,253 commits into from

Conversation

mayankjuneja
Copy link

No description provided.

@mayankjuneja
Copy link
Author

meow @vinaykakade
Syncing master with open source katib master.

tenzen-y and others added 29 commits November 3, 2022 11:14
…/setup-python version (#1996)

* [chore] Upgrade docker/metadata-action to v4

Signed-off-by: tenzen-y <[email protected]>

* [chore] Upgrade actions/checkout to v3

Signed-off-by: tenzen-y <[email protected]>

* [chore] Upgrade action/setup-python version to v4

Signed-off-by: tenzen-y <[email protected]>

Signed-off-by: tenzen-y <[email protected]>
* Support for k8s v1.25 in CI

* Revert "Support for k8s v1.25 in CI"

This reverts commit 16e6fe4.

* Support for k8s v1.25 in CI

* Support for k8s v1.25 in CI

* Support for k8s v1.25 in CI

* Add Readme changes
* Rename the Age header to Created at and right align it.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>
…#2003)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tend (#2005)

Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* gh-actions: Extend action to run Frontend Unit tests

Extend Frontend Test action to run also KWA frontend unit tests.

Signed-off-by: Orfeas Kourkakis <[email protected]>

* gh-actions: Exclude actions when there are only UI changes

Prevent the following workflows when a PR contains changes that affect
only the frontend:
 - Charmed Katib
 - E2E Test with darts-cnn-cifar10
 - E2E Test with enas-cnn-cifar10
 - E2E Test with mxnet-mnist
 - E2E Test with pytorch-mnist
 - E2E Test with simple-pbt
 - E2E Test with tf-mnist-with-summaries
 - Go Test
 - Publish AutoML Algorithm Images
 - Publish Katib Core Images
 - Publish Trial Images
 - Python Test
 - Shellcheck

Signed-off-by: Orfeas Kourkakis <[email protected]>

* gh-actions: Add action to build Katib UI image.

Signed-off-by: Orfeas Kourkakis <[email protected]>

Signed-off-by: Orfeas Kourkakis <[email protected]>
…1991)

* Introduce the kfp-run component as a distinct component.
* Make the pipeline button a link.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>
Fix 500 error when refreshing KWA's detail page by also adding the
namespace variable as a query param to the route.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>
…#2012)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.1...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Introduce COMMIT file that contains the commit where Katib needs to
checkout inside Kubeflow's common code in order to be built. This file
was integrated in the following places as well, thus a developer may
only update one file each time we need to checkout to a newer commit.
 - Dockerfile
 - GH actions
 - README.md

Signed-off-by: Orfeas Kourkakis <[email protected]>

Signed-off-by: Orfeas Kourkakis <[email protected]>
)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.3...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* kwa(front): Add new Editor component

Import new Editor component from Kubeflow Common Library and replace
all instances of previous Ace Editor.

Signed-off-by: Orfeas Kourkakis <[email protected]>

* Update COMMIT file to a more recent one in Kubeflow

Signed-off-by: Orfeas Kourkakis <[email protected]>

Signed-off-by: Orfeas Kourkakis <[email protected]>
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Commits](isaacs/minimatch@v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/tf-mnist-with-summaries (#2030)

Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.9.1 to 2.9.3.
- [Release notes](https://github.com/tensorflow/tensorflow/releases)
- [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md)
- [Commits](tensorflow/tensorflow@v2.9.1...v2.9.3)

---
updated-dependencies:
- dependency-name: tensorflow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/enas-cnn-cifar10 (#2031)

Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.9.1 to 2.9.3.
- [Release notes](https://github.com/tensorflow/tensorflow/releases)
- [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md)
- [Commits](tensorflow/tensorflow@v2.9.1...v2.9.3)

---
updated-dependencies:
- dependency-name: tensorflow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2032)

Bumps [engine.io](https://github.com/socketio/engine.io) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md)
- [Commits](socketio/engine.io@6.2.0...6.2.1)

---
updated-dependencies:
- dependency-name: engine.io
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tfevent-metricscollector (#2028)

Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.9.1 to 2.9.3.
- [Release notes](https://github.com/tensorflow/tensorflow/releases)
- [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md)
- [Commits](tensorflow/tensorflow@v2.9.1...v2.9.3)

---
updated-dependencies:
- dependency-name: tensorflow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [bugfix] Fix value passing bug in New Experiment form

Add missing logic in New Experiment form in order to pass the value
of the editor content in Metrics Collector tab, when Kind is set to
Custom.

* Adjust unit tests for custom yaml metrics collector
* UI(back): Add authorization mechanisms in new Katib UI backend

* Introduce helper ENV vars and functions for authentication and
  authorization checks. The authz checks are using SubjectAcessReviews
  objects.
  * BACKEND_MODE={dev,prod}: skip authz when in dev mode
  * APP_DISABLE_AUTH={bool}: skip authz if explicity requested

* Introduce a client-go client to construct SubjectAccessReview objects.

* Before any request proceed to K8s api-server:
  * check if authorization must be skipped (BACKEND_MODE, APP_DISBLE_AUTH)
  * check if a username is proviced in request Header
  * query the K8s api-server with SAR to ensure that the user has
    appropriate access privilleges

* Replace the /katib/fetch_experiment/ route with /katib/fetch_namespaces_experiments.
  This route expects a namespace as a query parameter from which all experiments will be fetched.

Signed-off-by: Apostolos Gerakaris <[email protected]>

* UI(front): Provide a namespace as a query parameter

This is needed for the new /katib/fetch_namespaced_experiments route.

Signed-off-by: Apostolos Gerakaris <[email protected]>

* Update README for running locally without auth

Update the README of the web app to expose that devs should set
APP_DISABLE_AUTH=true when running locally, since there's no authnz when
running locally.

Signed-off-by: Apostolos Gerakaris <[email protected]>

* remove duplicated variable types

Signed-off-by: Apostolos Gerakaris <[email protected]>

* Review fixes

* proper error handling.
* switch to Go's build-in errors package.
* set appropriate verbs when constructing SAR objects.

Signed-off-by: Apostolos Gerakaris <[email protected]>

* review: Use controller-runtime client to create SAR objects

Signed-off-by: Apostolos Gerakaris <[email protected]>

* Review fixes

* fix backend routes.
  * '/katib/fetch_namespaces' to fetch experiments in a namespace
  * 'FetchExperiments' handler

* hit the appropriate route from frontend and provide namespace as a
  query parameter  to fetch experiments

* remove remove BACKEND_MODE env var in
  favour of the more specific APP_DISABLE_AUTH

Signed-off-by: Apostolos Gerakaris <[email protected]>

* Review fixes

* Add constants for CRUD actions
* Add plural for experiments and suggestions as constants
* Add GetUsername logic under IsAuthorized and handle errors properly
* Have APP_DISABLE_AUTH by default as true, since currently Katib
  doesn't support this feature in standalone mode.

Signed-off-by: Apostolos Gerakaris <[email protected]>

Signed-off-by: Apostolos Gerakaris <[email protected]>
* [Test] Reduce Katib GitHub Action Runs

* Add cancel-in-progress flag

* Use single job for Charmed Katib

* Add cancel-in-progress for all actions except publish

* Bump ubuntu to 20.04 for Charmed tests
* frontend: Create a yaml tab for Trials (#2011)

* Create a dedicated yaml tab for Trials.

Signed-off-by: Elena Zioga <[email protected]>

* frontend: Rename components

* Rename trial-modal component to trial-details.
* Rename trial-modal-overview component to trial-overview.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>
…a1 (#2029)

Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.9.1 to 2.9.3.
- [Release notes](https://github.com/tensorflow/tensorflow/releases)
- [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md)
- [Commits](tensorflow/tensorflow@v2.9.1...v2.9.3)

---
updated-dependencies:
- dependency-name: tensorflow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build: Update the COMMIT file

* Update the COMMIT file.

Signed-off-by: Elena Zioga <[email protected]>

* frontend: Support paging/sorting/filtering in trials table (#1441)

* Make trials table support paging, sorting and filtering.

Signed-off-by: Elena Zioga <[email protected]>

* frontend: Create unit tests for trials table (#1441)

* Create unit tests for trials-table component.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>
* frontend: Remove TSLint

Remove TSLint since it's deprecated.

Signed-off-by: Elena Zioga <[email protected]>

* frontend: Introduce ESLint

Introduce ESLint by using the following Angular command [1]:

ng add @angular-eslint/schematics

[1] https://github.com/angular-eslint/angular-eslint#quick-start-with-angular-v12-and-later

Signed-off-by: Elena Zioga <[email protected]>

* frontend: Fix linting errors

Fix linting errors.

Signed-off-by: Elena Zioga <[email protected]>

* gh-actions: Add GH action to run a lint check

Introduce a Github action to run a lint check.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>
Ygnas and others added 30 commits August 22, 2024 15:33
… dir for black and flake8 (#2413)

* Chnage the isort profile to black, and add pkg dir for black and flake8

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fix the formating

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fix flake8 lint issues

Signed-off-by: Ignas Baranauskas <[email protected]>

---------

Signed-off-by: Ignas Baranauskas <[email protected]>
* fix: fix bugs in report_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in tune.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in get_trial_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update .gitignore and setup.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update Makefile.

Signed-off-by: Electronic-Waste <[email protected]>

* feat: add report_metrics_test.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix lint error.

Signed-off-by: Electronic-Waste <[email protected]>

* feat: add UTs for get_trial_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update post_gen.py.

Signed-off-by: Electronic-Waste <[email protected]>

* refactor: rebase to master.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): use single katib_client.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): add TODO for import rewrite.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): fix lint error with black.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): fix lint error with isort.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): reformat import in katib_client_test.py.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
* update tune api for llm hyperparameters optimization

Signed-off-by: helenxie-bit <[email protected]>

* resolve conflict

Signed-off-by: helenxie-bit <[email protected]>

* fix the problem of dependency

Signed-off-by: helenxie-bit <[email protected]>

* fix the format of import statement

Signed-off-by: helenxie-bit <[email protected]>

* adjust the blank lines

Signed-off-by: helenxie-bit <[email protected]>

* delete the trainer to reuse it in Training Operator

Signed-off-by: helenxie-bit <[email protected]>

* update constants

Signed-off-by: helenxie-bit <[email protected]>

* update metrics format

Signed-off-by: helenxie-bit <[email protected]>

* update the type of  and

Signed-off-by: helenxie-bit <[email protected]>

* update the message of 'ImportError'

Signed-off-by: helenxie-bit <[email protected]>

* add TODO of PVC creation

Signed-off-by: helenxie-bit <[email protected]>

* update the name of pvc

Signed-off-by: helenxie-bit <[email protected]>

* reuse constants from Training Operator

Signed-off-by: helenxie-bit <[email protected]>

* keep 'parameters' and update validation

Signed-off-by: helenxie-bit <[email protected]>

* update for test

Signed-off-by: helenxie-bit <[email protected]>

* reuse 'get_container_spec' and 'get_pod_template_spec' from Training Operator

Signed-off-by: helenxie-bit <[email protected]>

* format with black

Signed-off-by: helenxie-bit <[email protected]>

* fix Lint error

Signed-off-by: helenxie-bit <[email protected]>

* fix Lint errors

Signed-off-by: helenxie-bit <[email protected]>

* delete types

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* fix e2e test error

Signed-off-by: helenxie-bit <[email protected]>

* add TODO

Signed-off-by: helenxie-bit <[email protected]>

* format with max line length

Signed-off-by: helenxie-bit <[email protected]>

* format docstring

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* add helper functions

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* run test again

Signed-off-by: helenxie-bit <[email protected]>

* run test again

Signed-off-by: helenxie-bit <[email protected]>

* run test again

Signed-off-by: helenxie-bit <[email protected]>

* fix dict substitution in training_parameters

Signed-off-by: helenxie-bit <[email protected]>

* fix typo

Signed-off-by: helenxie-bit <[email protected]>

* resolve conflicts and add check for case of no parameters

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix flake8 error

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* update isort file to black and fix typo

Signed-off-by: helenxie-bit <[email protected]>

* modify the set of metrics format

Signed-off-by: helenxie-bit <[email protected]>

* update tune API

Signed-off-by: helenxie-bit <[email protected]>

* add types.TrainerResources class

Signed-off-by: helenxie-bit <[email protected]>

* fix flake8 error

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* resolve conflict

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* delete properties of 'TrainerResources'

Signed-off-by: helenxie-bit <[email protected]>

* fix format error

Signed-off-by: helenxie-bit <[email protected]>

* update types

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* add import of 'TrainerResources' in '__init__.py' of katib

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* revert changes and rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* check pvc and pv status of katib deployments

Signed-off-by: helenxie-bit <[email protected]>

* check pvc and pv status of katib deployments

Signed-off-by: helenxie-bit <[email protected]>

* recommit changes

Signed-off-by: helenxie-bit <[email protected]>

* update minikube version when setup

Signed-off-by: helenxie-bit <[email protected]>

* delete the code that disables formatting for the tune function

Signed-off-by: helenxie-bit <[email protected]>

* update according to andrey's feedback

Signed-off-by: helenxie-bit <[email protected]>

* add helper function in utils

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* move metrics_collector_spec back & update helper functions & add return type for helper functions

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* fix some typos

Signed-off-by: helenxie-bit <[email protected]>

* simplify the definition of 'TrainerResources'

Signed-off-by: helenxie-bit <[email protected]>

---------

Signed-off-by: helenxie-bit <[email protected]>
Signed-off-by: helenxie-bit <[email protected]>
* chore: add condition branch in requeue logic.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add ReportObservationLog in katib_manager_util.go.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add ReportTrialUnavailableMetrics func.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: insert unavailable value into Katib DB.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix lint error.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: add nil condition judgement.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: add nil condition judgement in trial_controller_util.go

Signed-off-by: Electronic-Waste <[email protected]>

* chore(trial): delete nil check of MC kind in the Trial controller.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(trial): init MC in newFakeTrialBatchJob to avoid nil condition in trial reconcile loop.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): fix lint error.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): fix lint error in controller.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): add integration test for Push MC.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(trial): retry reconcilation when reporting unavailable metrics failed.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): fix EXPECT order.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): fix typo error.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(trial): add errReportMetricsFailed.

Signed-off-by: Electronic-Waste <[email protected]>

* Update pkg/controller.v1beta1/trial/trial_controller.go

Co-authored-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>

* Update pkg/controller.v1beta1/trial/trial_controller_util.go

Co-authored-by: Yuki Iwai <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>

* Update pkg/controller.v1beta1/trial/trial_controller.go

Co-authored-by: Yuki Iwai <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): rename errors pkg.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): update the order of UT.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): use different names for UTs.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): separate Push MC UTs with original UTs.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): fix line error with gofmt.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): reserve one UT for Push MC.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): fix typo error.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): make some tiny changes.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): move cancel func to t.Cleanup.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): use the propagated gomega instance to improve debuggability.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): use gofmt to reformat code.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
Co-authored-by: Andrey Velichkevich <[email protected]>
Co-authored-by: Yuki Iwai <[email protected]>
Signed-off-by: Gonçalo Montalvão Marques <[email protected]>
Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/golang-jwt/jwt/releases)
- [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md)
- [Commits](golang-jwt/jwt@v4.5.0...v4.5.1)

---
updated-dependencies:
- dependency-name: github.com/golang-jwt/jwt/v4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: fix the broken link.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(doc): update guidance in multi-users pipelines setup.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
* fix(ui): update None Collector with Push Collector.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(ui): replace some remaining None MC.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
…sal directory and rename it (#2472)

- remove redundant folder

Signed-off-by: mahdikhashan <[email protected]>
* chore: update go.mod & go mod tidy.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: replace source.Kind and EnqueueRequestForXxx with typed func call.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update admission.Decoder in webhook.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update Makefile.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update codegen script.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: execute update-codegen.sh.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update openapigen & generate new openapi definitions.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix typo error.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update k8s version in CI.

Signed-off-by: Electronic-Waste <[email protected]>

* test(codegen): output CODEGEN_PKG.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(codegen): move shell check annotation.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(ci): change k8s version in go test to 1.30.0.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove toolchain declaration in go.mod

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove codegen dependency in openapigen.sh.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in recursive dir detection.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove a blank line.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: remove klog/v2

Signed-off-by: Electronic-Waste <[email protected]>

* chore(codegen): add three dots in the comment.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(codegen): fix package dependency on k8s.io/code-generator.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(Makefile): add go-mod-download.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
* chore(ci): add k8s version 1.31.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(Makefile): upgrade envtest version to 1.31 & setup-envtest to release-0.19.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update k8s related package in go.mod

Signed-off-by: Electronic-Waste <[email protected]>

* chore: make generate.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(test): add SkipNameValidation option to test frame.

Signed-off-by: Electronic-Waste <[email protected]>

* refactor(grpc): remove deprecated grpc.Dial implementation.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(dependency): remove dependency on k8s v1.28

Signed-off-by: Electronic-Waste <[email protected]>

* fix: add type assertion to ptr.To

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.31.0.
- [Commits](golang/crypto@v0.21.0...v0.31.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Upgrade klog dependency to v2

Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Xinmin Du <[email protected]>

* fix: fix conflict with k8s upate

Signed-off-by: Xinmin Du <[email protected]>

---------

Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Du Xinmin <[email protected]>
Co-authored-by: Xinmin Du <[email protected]>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.27.0 to 0.33.0.
- [Commits](golang/net@v0.27.0...v0.33.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…missionWebhookMatchConditions (#2241)

Signed-off-by: lianghao208 <[email protected]>
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.19.2...4.21.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) from 1.7.2 to 1.7.9.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.7.2...v1.7.9)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix tune api error

Signed-off-by: helenxie-bit <[email protected]>

* delete check for

Signed-off-by: helenxie-bit <[email protected]>

---------

Signed-off-by: helenxie-bit <[email protected]>
* add unit tests for tune api

Signed-off-by: helenxie-bit <[email protected]>

* update

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* update unit tests and fix api errors

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* test

Signed-off-by: helenxie-bit <[email protected]>

* test

Signed-off-by: helenxie-bit <[email protected]>

* update unit tests

Signed-off-by: helenxie-bit <[email protected]>

* undo changes to Makefile

Signed-off-by: helenxie-bit <[email protected]>

* delete debug code

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* update unit test

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* update the version of training operator

Signed-off-by: helenxie-bit <[email protected]>

* adjust 'list_namespaced_persistent_volume_claim' to be called with keyword argument

Signed-off-by: helenxie-bit <[email protected]>

* create constant for namespace when check pvc creation error

Signed-off-by: helenxie-bit <[email protected]>

* add type check for 'trainer_parameters'

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* update test names

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* add verification for key Experiment information & add 'kubeflow-training[huggingface' into dependencies

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* add verification for objective metric name

Signed-off-by: helenxie-bit <[email protected]>

* delete unnecessary changes

Signed-off-by: helenxie-bit <[email protected]>

* unify objective function

Signed-off-by: helenxie-bit <[email protected]>

* unify objective function

Signed-off-by: helenxie-bit <[email protected]>

---------

Signed-off-by: helenxie-bit <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.