Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HACK-2024] Add Workaround for Bot Thread Response #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[HACK-2024] Add Workaround for Bot Thread Response #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion omnibot/services/slack/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def _check_unsupported(self):
logger.debug("ignoring message from slackbot", extra=self.event_trace)
unsupported = True
# Ignore threads
elif self.thread_ts:
elif self.thread_ts and not self._payload.get("bot", {}).get("bot_id") == "A06SS17UFFW":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bot at Lyft? Maybe it would be better to make this a configurable option, then to include the list of bots to be ignored in the config instead?

logger.debug("ignoring thread message", extra=self.event_trace)
unsupported = True
# For now, ignore all event subtypes
Expand Down
Loading