Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support for truncate table query parsing (#1) #521

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

T-Santos
Copy link
Contributor

@T-Santos T-Santos commented Aug 14, 2024

Resolves #520

@macbre macbre self-assigned this Aug 24, 2024
test/test_truncate_table.py Outdated Show resolved Hide resolved
Copy link
Owner

@macbre macbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR! One comment left regarding the code formatting.

@macbre macbre enabled auto-merge (squash) August 24, 2024 20:15
auto-merge was automatically disabled August 26, 2024 16:57

Head branch was pushed to by a user without write access

T-Santos and others added 2 commits August 26, 2024 12:58
* failing test for truncate table

* fix failing truncate table test

---------

Co-authored-by: Santos, Tyler (Boston) <[email protected]>
@T-Santos
Copy link
Contributor Author

@macbre please let me know if there's anything else needed from me to move this forward. thank you

Copy link
Owner

@macbre macbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great, thanks!

@macbre macbre merged commit 3713f14 into macbre:master Aug 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse does not support truncate table <tablename> queries
2 participants