-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve spec compliance, Android interim results, iOS fix for simultaneous speech synthesis. #114
base: master
Are you sure you want to change the base?
Conversation
The event handler now uses the SpeechRecognitionError object.
… speechRecognitionAllowAudioOutput
Wow, awesome work, but please, keep Pull Requests simple, it's preferable that you send 5-6 separate PRs, (one per feature/bug), so it's easier to review and merge. |
I fixed what I needed locally and then decided that I should give it back to the community and pushed up my local changes. I don't spend much time on Github and it would only let me submit a PR from the head of my master branch. I don't have time to break it out into individual branches so I figured that one bigger PR is better than not doing it at all. Assuming that you have visibility into the individual commits, they are smaller and fairly self contained. It is likely to be easier to review each commit separately than to review the combined changes for the PR. |
…alized due to changes to sampleRate. Clean up iOS logging. Added iOS plugin status return for init().
Description
Related Issues
Motivation and Context
Improves ability to use the same application code for Android, and iOS apps as well as for Chrome.
How Has This Been Tested?
Works in my test app for Android and iOS. The same app code also works in Chrome.
Types of changes
Checklist: