apply cran reviewer comments (#20)

macmillancontentscience · Feb 8, 2021 · 3c0cfb7 · 3c0cfb7
1 parent 04c99c6
commit 3c0cfb7
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: wordpiece
 Type: Package
 Title: R Implementation of Wordpiece Tokenization
-Version: 1.0.1
+Version: 1.0.2
 Authors@R: c(
     person(given = "Jonathan",
            family = "Bratt",
@@ -13,7 +13,7 @@ Authors@R: c(
            role = c("aut"),
            email = "[email protected]",
            comment = c(ORCID = "0000-0003-4781-4346")),
-    person(given = "Macmillan Learning", 
+    person(given = "Bedford Freeman & Worth Pub Grp LLC DBA Macmillan Learning", 
            role = c("cph"))
     )
 Description: Apply 'Wordpiece' (<arXiv:1609.08144>) tokenization to input text, 

diff --git a/R/utils.R b/R/utils.R
@@ -20,6 +20,7 @@
 #' Mostly copied from rlang package.
 #'
 #' @param x,y If `x` is NULL, will return `y`; otherwise returns `x`.
+#' @return Returns `x` if `x` is not NULL; otherwise returns `y`.
 #' @keywords internal
 #' @name op-null-default
 `%||%` <- function(x, y) {

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,3 +1,11 @@
+## v. 1.0.2
+* Resubmitting 2021-02-08
+* Put the full company identifier in `Authors@R`: 
+Bedford Freeman & Worth Pub Grp LLC DBA Macmillan Learning. Previously, just
+the short name "Macmillan Learning" was listed in `Authors@R`.
+* Added `\value` field to documentation for the unexported function `%||%`.
+
+
 ## v. 1.0.1
 * Resubmitting 2021-02-02
 * Fixed the outdated URLs in the README

diff --git a/man/op-null-default.Rd b/man/op-null-default.Rd